Commit 8014097f authored by Bartosz Golaszewski's avatar Bartosz Golaszewski
Browse files

gpiolib: remove unneeded WARN_ON() from gpiochip_set_multiple() 



GPIO drivers are not required to support set_multiple() - the core will
fallback to calling set() for each line if it's missing. Remove the
offending check from gpiochip_set_multiple().

Fixes: 98ce1eb1 ("gpiolib: introduce gpio_chip setters that return values")
Reported-by: default avatarMarek Szyprowski <m.szyprowski@samsung.com>
Closes: https://lore.kernel.org/all/ab3e42c0-70fa-48e0-ac93-ecbffef63507@samsung.com/


Reviewed-by: default avatarLinus Walleij <linus.walleij@linaro.org>
Link: https://lore.kernel.org/r/20250227152831.59784-1-brgl@bgdev.pl


Signed-off-by: default avatarBartosz Golaszewski <bartosz.golaszewski@linaro.org>
parent cc76847b

drivers/gpio/gpiolib.c

+0 −3
Original line number Diff line number Diff line
@@ -3604,9 +3604,6 @@ static int gpiochip_set_multiple(struct gpio_chip *gc, 


	lockdep_assert_held(&gc->gpiodev->srcu);



	if (WARN_ON(unlikely(!gc->set_multiple && !gc->set_multiple_rv)))

		return -EOPNOTSUPP;



	if (gc->set_multiple_rv) {

		ret = gc->set_multiple_rv(gc, mask, bits);

		if (ret > 0)