Commit 80164282 authored by Kunwu Chan's avatar Kunwu Chan Committed by Will Deacon
Browse files

kselftest: arm64: Add a null pointer check 



There is a 'malloc' call, which can be unsuccessful.
This patch will add the malloc failure checking
to avoid possible null dereference and give more information
about test fail reasons.

Signed-off-by: default avatarKunwu Chan <chentao@kylinos.cn>
Reviewed-by: default avatarMuhammad Usama Anjum <usama.anjum@collabora.com>
Link: https://lore.kernel.org/r/20240423082102.2018886-1-chentao@kylinos.cn


Signed-off-by: default avatarWill Deacon <will@kernel.org>
parent b7fab1b6

tools/testing/selftests/arm64/tags/tags_test.c

+4 −0
Original line number Diff line number Diff line
@@ -6,6 +6,7 @@ 
#include <stdint.h>

#include <sys/prctl.h>

#include <sys/utsname.h>

#include "../../kselftest.h"



#define SHIFT_TAG(tag)		((uint64_t)(tag) << 56)

#define SET_TAG(ptr, tag)	(((uint64_t)(ptr) & ~SHIFT_TAG(0xff)) | \
@@ -21,6 +22,9 @@ int main(void) 
	if (prctl(PR_SET_TAGGED_ADDR_CTRL, PR_TAGGED_ADDR_ENABLE, 0, 0, 0) == 0)

		tbi_enabled = 1;

	ptr = (struct utsname *)malloc(sizeof(*ptr));

	if (!ptr)

		ksft_exit_fail_msg("Failed to allocate utsname buffer\n");



	if (tbi_enabled)

		tag = 0x42;

	ptr = (struct utsname *)SET_TAG(ptr, tag);