Commit 804d514d authored by Oded Gabbay's avatar Oded Gabbay Committed by Greg Kroah-Hartman
Browse files

habanalabs: return -EFAULT on copy_to_user error 



If copy_to_user failed in info ioctl, we always return -EFAULT so the
user will know there was an error.

Reported-by: default avatarkernel test robot <lkp@intel.com>
Reported-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarOded Gabbay <ogabbay@kernel.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 49d2a8af

drivers/misc/habanalabs/common/habanalabs_ioctl.c

+1 −3
Original line number Diff line number Diff line
@@ -118,7 +118,6 @@ static int hw_events_info(struct hl_device *hdev, bool aggregate, 


static int events_info(struct hl_fpriv *hpriv, struct hl_info_args *args)

{

	int rc;

	u32 max_size = args->return_size;

	u64 events_mask;

	void __user *out = (void __user *) (uintptr_t) args->return_pointer;
@@ -131,8 +130,7 @@ static int events_info(struct hl_fpriv *hpriv, struct hl_info_args *args) 
	hpriv->notifier_event.events_mask = 0;

	mutex_unlock(&hpriv->notifier_event.lock);



	rc = copy_to_user(out, &events_mask, sizeof(u64));

	return rc;

	return copy_to_user(out, &events_mask, sizeof(u64)) ? -EFAULT : 0;

}



static int dram_usage_info(struct hl_fpriv *hpriv, struct hl_info_args *args)