Commit 8053f49f authored by Steven Rostedt's avatar Steven Rostedt Committed by Steven Rostedt (Google)
Browse files

tracing: Remove duplicate latency_fsnotify() stub 

When the SNAPSHOT is defined but FSNOTIFY is not the latency_fsnotify()
function is turned into a static inline stub. But this stub was defined in
both trace.h and trace_snapshot.c causing a error in build when
CONFIG_SNAPSHOT is defined but FSNOTIFY is not. The stub is not needed in
trace_snapshot.c as it will be defined in trace.h, remove it from the C
file.

Cc: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Link: https://patch.msgid.link/20260330205859.24c0aae3@gandalf.local.home


Fixes: bade44fe ("tracing: Move snapshot code out of trace.c and into trace_snapshot.c")
Reported-by: default avatarkernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202603310604.lGE9LDBK-lkp@intel.com/


Signed-off-by: default avatarSteven Rostedt (Google) <rostedt@goodmis.org>
parent d1a03c29

kernel/trace/trace.h

+1 −1
Original line number Diff line number Diff line
@@ -845,13 +845,13 @@ void update_max_tr_single(struct trace_array *tr, 
#if defined(CONFIG_TRACER_MAX_TRACE) && defined(CONFIG_FSNOTIFY)

# define LATENCY_FS_NOTIFY

#endif

#endif /* CONFIG_TRACER_SNAPSHOT */



#ifdef LATENCY_FS_NOTIFY

void latency_fsnotify(struct trace_array *tr);

#else

static inline void latency_fsnotify(struct trace_array *tr) { }

#endif

#endif /* CONFIG_TRACER_SNAPSHOT */



#ifdef CONFIG_STACKTRACE

void __trace_stack(struct trace_array *tr, unsigned int trace_ctx, int skip);

kernel/trace/trace_snapshot.c

+1 −2
Original line number Diff line number Diff line
@@ -391,9 +391,8 @@ void latency_fsnotify(struct trace_array *tr) 
	 */

	irq_work_queue(&tr->fsnotify_irqwork);

}

#else

static inline void latency_fsnotify(struct trace_array *tr) { }

#endif /* LATENCY_FS_NOTIFY */



static const struct file_operations tracing_max_lat_fops;



void trace_create_maxlat_file(struct trace_array *tr,