Commit 80626ae6 authored by Colin Ian King's avatar Colin Ian King Committed by Danilo Krummrich
Browse files

drm/nouveau/gsp: Fix potential integer overflow on integer shifts 



The left shift int 32 bit integer constants 1 is evaluated using 32 bit
arithmetic and then assigned to a 64 bit unsigned integer. In the case
where the shift is 32 or more this can lead to an overflow. Avoid this
by shifting using the BIT_ULL macro instead.

Fixes: 6c3ac7bc ("drm/nouveau/gsp: support deeper page tables in COPY_SERVER_RESERVED_PDES")
Signed-off-by: default avatarColin Ian King <colin.i.king@gmail.com>
Signed-off-by: default avatarDanilo Krummrich <dakr@kernel.org>
Link: https://lore.kernel.org/r/20250522131512.2768310-1-colin.i.king@gmail.com
parent 2e3395ab

drivers/gpu/drm/nouveau/nvkm/subdev/gsp/rm/r535/vmm.c

+1 −1
Original line number Diff line number Diff line
@@ -121,7 +121,7 @@ r535_mmu_vaspace_new(struct nvkm_vmm *vmm, u32 handle, bool external) 
			page_shift -= desc->bits;



			ctrl->levels[i].physAddress = pd->pt[0]->addr;

			ctrl->levels[i].size = (1 << desc->bits) * desc->size;

			ctrl->levels[i].size = BIT_ULL(desc->bits) * desc->size;

			ctrl->levels[i].aperture = 1;

			ctrl->levels[i].pageShift = page_shift;