Commit 8079b87c authored by Jesse.Zhang's avatar Jesse.Zhang Committed by Alex Deucher
Browse files

drm/amdgpu: validate user queue size constraints 



Add validation to ensure user queue sizes meet hardware requirements:
- Size must be a power of two for efficient ring buffer wrapping
- Size must be at least AMDGPU_GPU_PAGE_SIZE to prevent undersized allocations

This prevents invalid configurations that could lead to GPU faults or
unexpected behavior.

Reviewed-by: default avatarChristian König <christian.koenig@amd.com>
Signed-off-by: default avatarJesse Zhang <jesse.zhang@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent ba205ac3

drivers/gpu/drm/amd/amdgpu/amdgpu_userq.c

+11 −0
Original line number Diff line number Diff line
@@ -932,6 +932,17 @@ static int amdgpu_userq_input_args_validate(struct drm_device *dev, 
			drm_file_err(filp, "invalidate userq queue va or size\n");

			return -EINVAL;

		}



		if (!is_power_of_2(args->in.queue_size)) {

			drm_file_err(filp, "Queue size must be a power of 2\n");

			return -EINVAL;

		}



		if (args->in.queue_size < AMDGPU_GPU_PAGE_SIZE) {

			drm_file_err(filp, "Queue size smaller than AMDGPU_GPU_PAGE_SIZE\n");

			return -EINVAL;

		}



		if (!args->in.wptr_va || !args->in.rptr_va) {

			drm_file_err(filp, "invalidate userq queue rptr or wptr\n");

			return -EINVAL;