Commit 807babf6 authored by Umang Jain's avatar Umang Jain Committed by Greg Kroah-Hartman
Browse files

staging: vchiq_arm: Use devm_kzalloc() for drv_mgmt allocation 



The struct drv_mgmt 'mgmt' is currently allocated dynamically using
kzalloc(). Unfortunately, it is subjected to memory leaks in the error
handling paths of the probe() function.

To address this issue, use device resource management
helper devm_kzalloc(), to ensure cleanup after the allocation.

Cc: stable@vger.kernel.org
Fixes: 1c9e16b7 ("staging: vc04_services: vchiq_arm: Split driver static and runtime data")
Signed-off-by: default avatarUmang Jain <umang.jain@ideasonboard.com>
Reviewed-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Link: https://lore.kernel.org/r/20241016130225.61024-3-umang.jain@ideasonboard.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 404b739e

drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c

+1 −3
Original line number Diff line number Diff line
@@ -1731,7 +1731,7 @@ static int vchiq_probe(struct platform_device *pdev) 
		return -ENOENT;

	}



	mgmt = kzalloc(sizeof(*mgmt), GFP_KERNEL);

	mgmt = devm_kzalloc(&pdev->dev, sizeof(*mgmt), GFP_KERNEL);

	if (!mgmt)

		return -ENOMEM;
@@ -1789,8 +1789,6 @@ static void vchiq_remove(struct platform_device *pdev) 


	arm_state = vchiq_platform_get_arm_state(&mgmt->state);

	kthread_stop(arm_state->ka_thread);



	kfree(mgmt);

}



static struct platform_driver vchiq_driver = {