Commit 80da96d7 authored by Takashi Iwai's avatar Takashi Iwai Committed by Thomas Zimmermann
Browse files

drm/bochs: Fix DPMS regression 

The recent rewrite with the use of regular atomic helpers broke the
DPMS unblanking on X11.  Fix it by moving the call of
bochs_hw_blank(false) from CRTC mode_set_nofb() to atomic_enable().

Fixes: 20371749 ("drm/bochs: Use regular atomic helpers")
Link: https://bugzilla.suse.com/show_bug.cgi?id=1238209


Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
Reviewed-by: default avatarThomas Zimmermann <tzimmermann@suse.de>
Signed-off-by: default avatarThomas Zimmermann <tzimmermann@suse.de>
Link: https://patchwork.freedesktop.org/patch/msgid/20250304134203.20534-1-tiwai@suse.de
parent 23e0832d

drivers/gpu/drm/tiny/bochs.c

+3 −2
Original line number Diff line number Diff line
@@ -335,8 +335,6 @@ static void bochs_hw_setmode(struct bochs_device *bochs, struct drm_display_mode 
			 bochs->xres, bochs->yres, bochs->bpp,

			 bochs->yres_virtual);



	bochs_hw_blank(bochs, false);



	bochs_dispi_write(bochs, VBE_DISPI_INDEX_ENABLE,      0);

	bochs_dispi_write(bochs, VBE_DISPI_INDEX_BPP,         bochs->bpp);

	bochs_dispi_write(bochs, VBE_DISPI_INDEX_XRES,        bochs->xres);
@@ -506,6 +504,9 @@ static int bochs_crtc_helper_atomic_check(struct drm_crtc *crtc, 
static void bochs_crtc_helper_atomic_enable(struct drm_crtc *crtc,

					    struct drm_atomic_state *state)

{

	struct bochs_device *bochs = to_bochs_device(crtc->dev);



	bochs_hw_blank(bochs, false);

}



static void bochs_crtc_helper_atomic_disable(struct drm_crtc *crtc,