Commit 80db65d4 authored by Wentao Liang's avatar Wentao Liang Committed by Nishanth Menon
Browse files

soc: ti: pruss: Fix double free in pruss_clk_mux_setup() 



In the pruss_clk_mux_setup(), the devm_add_action_or_reset() indirectly
calls pruss_of_free_clk_provider(), which calls of_node_put(clk_mux_np)
on the error path. However, after the devm_add_action_or_reset()
returns, the of_node_put(clk_mux_np) is called again, causing a double
free.

Fix by returning directly, to avoid the duplicate of_node_put().

Fixes: ba59c9b4 ("soc: ti: pruss: support CORECLK_MUX and IEPCLK_MUX")
Cc: stable@vger.kernel.org
Signed-off-by: default avatarWentao Liang <vulab@iscas.ac.cn>
Link: https://patch.msgid.link/20260113014716.2464741-1-vulab@iscas.ac.cn


Signed-off-by: default avatarNishanth Menon <nm@ti.com>
parent c933138d

drivers/soc/ti/pruss.c

+2 −4
Original line number Diff line number Diff line
@@ -366,12 +366,10 @@ static int pruss_clk_mux_setup(struct pruss *pruss, struct clk *clk_mux, 


	ret = devm_add_action_or_reset(dev, pruss_of_free_clk_provider,

				       clk_mux_np);

	if (ret) {

	if (ret)

		dev_err(dev, "failed to add clkmux free action %d", ret);

		goto put_clk_mux_np;

	}



	return 0;

	return ret;



put_clk_mux_np:

	of_node_put(clk_mux_np);