Commit 80fea979 authored by Aleksandr Aprelkov's avatar Aleksandr Aprelkov Committed by Will Deacon
Browse files

iommu/arm-smmu-v3: Free MSIs in case of ENOMEM 



If devm_add_action() returns -ENOMEM, then MSIs are allocated but not
not freed on teardown. Use devm_add_action_or_reset() instead to keep
the static analyser happy.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Signed-off-by: default avatarAleksandr Aprelkov <aaprelkov@usergate.com>
Link: https://lore.kernel.org/r/20240403053759.643164-1-aaprelkov@usergate.com


[will: Tweak commit message, remove warning message]
Signed-off-by: default avatarWill Deacon <will@kernel.org>
parent d75d7dc2

drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c

+1 −1
Original line number Diff line number Diff line
@@ -3398,7 +3398,7 @@ static void arm_smmu_setup_msis(struct arm_smmu_device *smmu) 
	smmu->priq.q.irq = msi_get_virq(dev, PRIQ_MSI_INDEX);



	/* Add callback to free MSIs on teardown */

	devm_add_action(dev, arm_smmu_free_msis, dev);

	devm_add_action_or_reset(dev, arm_smmu_free_msis, dev);

}



static void arm_smmu_setup_unique_irqs(struct arm_smmu_device *smmu)