Commit 81122fba authored by Weigang He's avatar Weigang He Committed by Rob Herring (Arm)
Browse files

of: fix reference count leak in of_alias_scan() 



of_find_node_by_path() returns a device_node with its refcount
incremented. When kstrtoint() fails or dt_alloc() fails, the function
continues to the next iteration without calling of_node_put(), causing
a reference count leak.

Add of_node_put(np) before continue on both error paths to properly
release the device_node reference.

Fixes: 611cad72 ("dt: add of_alias_scan and of_alias_get_id")
Cc: stable@vger.kernel.org
Signed-off-by: default avatarWeigang He <geoffreyhe2@gmail.com>
Link: https://patch.msgid.link/20260117091238.481243-1-geoffreyhe2@gmail.com


Signed-off-by: default avatarRob Herring (Arm) <robh@kernel.org>
parent 48e6a9c4

drivers/of/base.c

+6 −2
Original line number Diff line number Diff line
@@ -1942,13 +1942,17 @@ void of_alias_scan(void * (*dt_alloc)(u64 size, u64 align)) 
			end--;

		len = end - start;



		if (kstrtoint(end, 10, &id) < 0)

		if (kstrtoint(end, 10, &id) < 0) {

			of_node_put(np);

			continue;

		}



		/* Allocate an alias_prop with enough space for the stem */

		ap = dt_alloc(sizeof(*ap) + len + 1, __alignof__(*ap));

		if (!ap)

		if (!ap) {

			of_node_put(np);

			continue;

		}

		memset(ap, 0, sizeof(*ap) + len + 1);

		ap->alias = start;

		of_alias_add(ap, np, id, start, len);