Commit 811dbc54 authored by Dikshita Agarwal's avatar Dikshita Agarwal Committed by Hans Verkuil
Browse files

media: iris: Skip resolution set on first IPSC 



The resolution property is not supposed to be set during reconfig.
Existing iris_drc_pending(inst) check is insufficient, as it doesn't
cover the first port setting change.

Extend the conditional check to also skip resolution setting when
the instance is in IRIS_INST_SUB_FIRST_IPSC.

Fixes: caf20554 ("media: iris: Avoid updating frame size to firmware during reconfig")
Reviewed-by: default avatarBryan O'Donoghue <bod@kernel.org>
Signed-off-by: default avatarDikshita Agarwal <dikshita.agarwal@oss.qualcomm.com>
Reviewed-by: default avatarVikash Garodia <vikash.garodia@oss.qualcomm.com>
Cc: stable@vger.kernel.org
Signed-off-by: default avatarBryan O'Donoghue <bod@kernel.org>
Signed-off-by: default avatarHans Verkuil <hverkuil+cisco@kernel.org>
parent 2d0bbd98

drivers/media/platform/qcom/iris/iris_hfi_gen1_command.c

+1 −1
Original line number Diff line number Diff line
@@ -733,7 +733,7 @@ static int iris_hfi_gen1_set_resolution(struct iris_inst *inst, u32 plane) 
	struct hfi_framesize fs;

	int ret;



	if (!iris_drc_pending(inst)) {

	if (!iris_drc_pending(inst) && !(inst->sub_state & IRIS_INST_SUB_FIRST_IPSC)) {

		fs.buffer_type = HFI_BUFFER_INPUT;

		fs.width = inst->fmt_src->fmt.pix_mp.width;

		fs.height = inst->fmt_src->fmt.pix_mp.height;