Unverified Commit 8138078d authored by Cristian Ciocaltea's avatar Cristian Ciocaltea Committed by Maxime Ripard
Browse files

drm/tests: hdmi: Add limited range tests for YUV420 mode 



Provide tests to verify that drm_atomic_helper_connector_hdmi_check()
helper behaviour when using YUV420 output format is to always set the
limited RGB quantization range to 'limited', no matter what the value of
Broadcast RGB property is.

Acked-by: default avatarMaxime Ripard <mripard@kernel.org>
Signed-off-by: default avatarCristian Ciocaltea <cristian.ciocaltea@collabora.com>
Link: https://lore.kernel.org/r/20250527-hdmi-conn-yuv-v5-15-74c9c4a8ac0c@collabora.com


Signed-off-by: default avatarMaxime Ripard <mripard@kernel.org>
parent 58fe1d78

drivers/gpu/drm/tests/drm_hdmi_state_helper_test.c

+103 −5
Original line number Diff line number Diff line
@@ -735,6 +735,107 @@ static void drm_test_check_broadcast_rgb_limited_cea_mode_vic_1(struct kunit *te 
	drm_modeset_acquire_fini(&ctx);

}



/*

 * Test that for an HDMI connector, with an HDMI monitor, we will

 * get a limited RGB Quantization Range with a YUV420 mode, no

 * matter what the value of the Broadcast RGB property is set to.

 */

static void drm_test_check_broadcast_rgb_cea_mode_yuv420(struct kunit *test)

{

	struct drm_atomic_helper_connector_hdmi_priv *priv;

	enum drm_hdmi_broadcast_rgb broadcast_rgb;

	struct drm_modeset_acquire_ctx ctx;

	struct drm_connector_state *conn_state;

	struct drm_atomic_state *state;

	struct drm_display_mode *mode;

	struct drm_connector *conn;

	struct drm_device *drm;

	struct drm_crtc *crtc;

	int ret;



	broadcast_rgb = *(enum drm_hdmi_broadcast_rgb *)test->param_value;



	priv = drm_kunit_helper_connector_hdmi_init_with_edid_funcs(test,

				BIT(HDMI_COLORSPACE_RGB) |

				BIT(HDMI_COLORSPACE_YUV420),

				8,

				&dummy_connector_hdmi_funcs,

				test_edid_hdmi_1080p_rgb_yuv_4k_yuv420_dc_max_200mhz);

	KUNIT_ASSERT_NOT_NULL(test, priv);



	drm = &priv->drm;

	crtc = priv->crtc;

	conn = &priv->connector;

	KUNIT_ASSERT_TRUE(test, conn->display_info.is_hdmi);



	mode = drm_kunit_display_mode_from_cea_vic(test, drm, 95);

	KUNIT_ASSERT_NOT_NULL(test, mode);



	drm_modeset_acquire_init(&ctx, 0);



retry_conn_enable:

	ret = drm_kunit_helper_enable_crtc_connector(test, drm, crtc, conn,

						     mode, &ctx);

	if (ret == -EDEADLK) {

		ret = drm_modeset_backoff(&ctx);

		if (!ret)

			goto retry_conn_enable;

	}

	KUNIT_ASSERT_EQ(test, ret, 0);



	state = drm_kunit_helper_atomic_state_alloc(test, drm, &ctx);

	KUNIT_ASSERT_NOT_ERR_OR_NULL(test, state);



retry_conn_state:

	conn_state = drm_atomic_get_connector_state(state, conn);

	if (PTR_ERR(conn_state) == -EDEADLK) {

		drm_atomic_state_clear(state);

		ret = drm_modeset_backoff(&ctx);

		if (!ret)

			goto retry_conn_state;

	}

	KUNIT_ASSERT_NOT_ERR_OR_NULL(test, conn_state);



	conn_state->hdmi.broadcast_rgb = broadcast_rgb;



	ret = drm_atomic_check_only(state);

	if (ret == -EDEADLK) {

		drm_atomic_state_clear(state);

		ret = drm_modeset_backoff(&ctx);

		if (!ret)

			goto retry_conn_state;

	}

	KUNIT_ASSERT_EQ(test, ret, 0);



	conn_state = drm_atomic_get_new_connector_state(state, conn);

	KUNIT_ASSERT_NOT_ERR_OR_NULL(test, conn_state);



	KUNIT_ASSERT_EQ(test, conn_state->hdmi.broadcast_rgb, broadcast_rgb);

	KUNIT_ASSERT_EQ(test, conn_state->hdmi.output_format, HDMI_COLORSPACE_YUV420);



	KUNIT_EXPECT_TRUE(test, conn_state->hdmi.is_limited_range);



	drm_modeset_drop_locks(&ctx);

	drm_modeset_acquire_fini(&ctx);

}



static const enum drm_hdmi_broadcast_rgb check_broadcast_rgb_cea_mode_yuv420_tests[] = {

	DRM_HDMI_BROADCAST_RGB_AUTO,

	DRM_HDMI_BROADCAST_RGB_FULL,

	DRM_HDMI_BROADCAST_RGB_LIMITED,

};



static void

check_broadcast_rgb_cea_mode_yuv420_desc(const enum drm_hdmi_broadcast_rgb *broadcast_rgb,

					 char *desc)

{

	sprintf(desc, "%s", drm_hdmi_connector_get_broadcast_rgb_name(*broadcast_rgb));

}



KUNIT_ARRAY_PARAM(check_broadcast_rgb_cea_mode_yuv420,

		  check_broadcast_rgb_cea_mode_yuv420_tests,

		  check_broadcast_rgb_cea_mode_yuv420_desc);



/*

 * Test that if we change the maximum bpc property to a different value,

 * we trigger a mode change on the connector's CRTC, which will in turn
@@ -1667,11 +1768,8 @@ static struct kunit_case drm_atomic_helper_connector_hdmi_check_tests[] = { 
	KUNIT_CASE(drm_test_check_broadcast_rgb_full_cea_mode_vic_1),

	KUNIT_CASE(drm_test_check_broadcast_rgb_limited_cea_mode),

	KUNIT_CASE(drm_test_check_broadcast_rgb_limited_cea_mode_vic_1),

	/*

	 * TODO: When we'll have YUV output support, we need to check

	 * that the limited range is always set to limited no matter

	 * what the value of Broadcast RGB is.

	 */

	KUNIT_CASE_PARAM(drm_test_check_broadcast_rgb_cea_mode_yuv420,

			 check_broadcast_rgb_cea_mode_yuv420_gen_params),

	KUNIT_CASE(drm_test_check_broadcast_rgb_crtc_mode_changed),

	KUNIT_CASE(drm_test_check_broadcast_rgb_crtc_mode_not_changed),

	KUNIT_CASE(drm_test_check_disable_connector),