Unverified Commit 813d39ba authored by Andrew Jones's avatar Andrew Jones Committed by Alexandre Ghiti
Browse files

riscv: Change check_unaligned_access_speed_all_cpus to void 



The return value of check_unaligned_access_speed_all_cpus() is always
zero, so make the function void so we don't need to concern ourselves
with it. The change also allows us to tidy up
check_unaligned_access_all_cpus() a bit.

Reviewed-by: default avatarClément Léger <cleger@rivosinc.com>
Reviewed-by: default avatarAlexandre Ghiti <alexghiti@rivosinc.com>
Signed-off-by: default avatarAndrew Jones <ajones@ventanamicro.com>
Link: https://lore.kernel.org/r/20250304120014.143628-14-ajones@ventanamicro.com


Signed-off-by: default avatarAlexandre Ghiti <alexghiti@rivosinc.com>
parent e6d0adf2

arch/riscv/kernel/unaligned_access_speed.c

+5 −10
Original line number Diff line number Diff line
@@ -218,7 +218,7 @@ static int riscv_offline_cpu(unsigned int cpu) 
}



/* Measure unaligned access speed on all CPUs present at boot in parallel. */

static int __init check_unaligned_access_speed_all_cpus(void)

static void __init check_unaligned_access_speed_all_cpus(void)

{

	unsigned int cpu;

	unsigned int cpu_count = num_possible_cpus();
@@ -226,7 +226,7 @@ static int __init check_unaligned_access_speed_all_cpus(void) 


	if (!bufs) {

		pr_warn("Allocation failure, not measuring misaligned performance\n");

		return 0;

		return;

	}



	/*
@@ -261,12 +261,10 @@ static int __init check_unaligned_access_speed_all_cpus(void) 
	}



	kfree(bufs);

	return 0;

}

#else /* CONFIG_RISCV_PROBE_UNALIGNED_ACCESS */

static int __init check_unaligned_access_speed_all_cpus(void)

static void __init check_unaligned_access_speed_all_cpus(void)

{

	return 0;

}

#endif
@@ -403,10 +401,10 @@ static int __init vec_check_unaligned_access_speed_all_cpus(void *unused __alway 


static int __init check_unaligned_access_all_cpus(void)

{

	bool all_cpus_emulated;

	int cpu;



	all_cpus_emulated = check_unaligned_access_emulated_all_cpus();

	if (!check_unaligned_access_emulated_all_cpus())

		check_unaligned_access_speed_all_cpus();



	if (!has_vector()) {

		for_each_online_cpu(cpu)
@@ -417,9 +415,6 @@ static int __init check_unaligned_access_all_cpus(void) 
			    NULL, "vec_check_unaligned_access_speed_all_cpus");

	}



	if (!all_cpus_emulated)

		return check_unaligned_access_speed_all_cpus();



	return 0;

}