Commit 815b6cb3 authored by Damien Le Moal's avatar Damien Le Moal
Browse files

ata: ahci_ceva: Fix id array access in ceva_ahci_read_id() 



ATA IDENTIFY command returns an array of le16 words. Accessing it as a
u16 array triggers the following sparse warning:

drivers/ata/ahci_ceva.c:107:33: warning: invalid assignment: &=
drivers/ata/ahci_ceva.c:107:33:    left side has type unsigned short
drivers/ata/ahci_ceva.c:107:33:    right side has type restricted __le16

Use a local variable to explicitly cast the id array to __le16 to avoid
this warning.

Signed-off-by: default avatarDamien Le Moal <damien.lemoal@opensource.wdc.com>
parent 0fcfb00b

drivers/ata/ahci_ceva.c

+2 −1
Original line number Diff line number Diff line
@@ -94,6 +94,7 @@ struct ceva_ahci_priv { 
static unsigned int ceva_ahci_read_id(struct ata_device *dev,

					struct ata_taskfile *tf, u16 *id)

{

	__le16 *__id = (__le16 *)id;

	u32 err_mask;



	err_mask = ata_do_dev_read_id(dev, tf, id);
@@ -103,7 +104,7 @@ static unsigned int ceva_ahci_read_id(struct ata_device *dev, 
	 * Since CEVA controller does not support device sleep feature, we

	 * need to clear DEVSLP (bit 8) in word78 of the IDENTIFY DEVICE data.

	 */

	id[ATA_ID_FEATURE_SUPP] &= cpu_to_le16(~(1 << 8));

	__id[ATA_ID_FEATURE_SUPP] &= cpu_to_le16(~(1 << 8));



	return 0;

}