Unverified Commit 816b2e60 authored by Christian Brauner's avatar Christian Brauner
Browse files

pidfs: switch to copy_struct_to_user() 

We have a helper that deals with all the required logic.

Link: https://lore.kernel.org/r/20250305-work-pidfs-kill_on_last_close-v3-1-c8c3d8361705@kernel.org


Reviewed-by: default avatarJeff Layton <jlayton@kernel.org>
Reviewed-by: default avatarOleg Nesterov <oleg@redhat.com>
Signed-off-by: default avatarChristian Brauner <brauner@kernel.org>
parent b1e809e7

fs/pidfs.c

+1 −4
Original line number Diff line number Diff line
@@ -276,10 +276,7 @@ static long pidfd_info(struct task_struct *task, unsigned int cmd, unsigned long 
	 * userspace knows about will be copied. If userspace provides a new

	 * struct, only the bits that the kernel knows about will be copied.

	 */

	if (copy_to_user(uinfo, &kinfo, min(usize, sizeof(kinfo))))

		return -EFAULT;



	return 0;

	return copy_struct_to_user(uinfo, usize, &kinfo, sizeof(kinfo), NULL);

}



static bool pidfs_ioctl_valid(unsigned int cmd)