Commit 8172f577 authored by Dikshita Agarwal's avatar Dikshita Agarwal Committed by Hans Verkuil
Browse files

media: iris: Fix missing LAST flag handling during drain 



Improve drain handling by ensuring the LAST flag is attached to final
capture buffer when drain response is received from the firmware.

Previously, the driver failed to attach the V4L2_BUF_FLAG_LAST flag when
a drain response was received from the firmware, relying on userspace to
mark the next queued buffer as LAST. This update fixes the issue by
checking the pending drain status, attaching the LAST flag to the
capture buffer received from the firmware (with EOS attached), and
returning it to the V4L2 layer correctly.

Fixes: d0910076 ("media: iris: add support for drain sequence")
Cc: stable@vger.kernel.org
Reviewed-by: default avatarVikash Garodia <quic_vgarodia@quicinc.com>
Tested-by: Vikash Garodia <quic_vgarodia@quicinc.com> # X1E80100
Reviewed-by: default avatarBryan O'Donoghue <bryan.odonoghue@linaro.org>
Tested-by: Neil Armstrong <neil.armstrong@linaro.org> # on SM8550-HDK
Tested-by: Neil Armstrong <neil.armstrong@linaro.org> # on SM8650-HDK
Signed-off-by: default avatarDikshita Agarwal <quic_dikshita@quicinc.com>
Tested-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> # x1e80100-crd
Signed-off-by: default avatarBryan O'Donoghue <bod@kernel.org>
Signed-off-by: default avatarHans Verkuil <hverkuil+cisco@kernel.org>
parent dec073dd

drivers/media/platform/qcom/iris/iris_hfi_gen1_response.c

+1 −3
Original line number Diff line number Diff line
@@ -416,8 +416,6 @@ static void iris_hfi_gen1_session_ftb_done(struct iris_inst *inst, void *packet) 
			inst->flush_responses_pending++;



		iris_inst_sub_state_change_drain_last(inst);



		return;

	}



	if (iris_split_mode_enabled(inst) && pkt->stream_id == 0) {
@@ -462,7 +460,7 @@ static void iris_hfi_gen1_session_ftb_done(struct iris_inst *inst, void *packet) 
		timestamp_us = (timestamp_us << 32) | timestamp_lo;

	} else {

		if (pkt->stream_id == 1 && !inst->last_buffer_dequeued) {

			if (iris_drc_pending(inst)) {

			if (iris_drc_pending(inst) || iris_drain_pending(inst)) {

				flags |= V4L2_BUF_FLAG_LAST;

				inst->last_buffer_dequeued = true;

			}

drivers/media/platform/qcom/iris/iris_state.c

+1 −1
Original line number Diff line number Diff line
@@ -252,7 +252,7 @@ bool iris_drc_pending(struct iris_inst *inst) 
		inst->sub_state & IRIS_INST_SUB_DRC_LAST;

}



static inline bool iris_drain_pending(struct iris_inst *inst)

bool iris_drain_pending(struct iris_inst *inst)

{

	return inst->sub_state & IRIS_INST_SUB_DRAIN &&

		inst->sub_state & IRIS_INST_SUB_DRAIN_LAST;

drivers/media/platform/qcom/iris/iris_state.h

+1 −0
Original line number Diff line number Diff line
@@ -141,5 +141,6 @@ int iris_inst_sub_state_change_drc_last(struct iris_inst *inst); 
int iris_inst_sub_state_change_pause(struct iris_inst *inst, u32 plane);

bool iris_allow_cmd(struct iris_inst *inst, u32 cmd);

bool iris_drc_pending(struct iris_inst *inst);

bool iris_drain_pending(struct iris_inst *inst);



#endif