Commit 817d2371 authored by Rafael J. Wysocki's avatar Rafael J. Wysocki
Browse files

Merge branches 'acpi-x86', 'acpi-video', 'acpi-apei' and 'acpi-misc'

Merge x86-specific ACPI changes, an ACPI backlight driver change, ACPI
APEI change and miscellaneous ACPI-related changes for 6.9-rc1:

 - Add DELL0501 handling to acpi_quirk_skip_serdev_enumeration() and
   make that function generic (Hans de Goede).

 - Make the ACPI backlight code handle fetching EDID that is longer than
   256 bytes (Mario Limonciello).

 - Skip initialization of GHES_ASSIST structures for Machine Check
   Architecture in APEI (Avadhut Naik).

 - Convert several plaform drivers in the ACPI subsystem to using a
   remove callback that returns void (Uwe Kleine-König).

 - Drop the long-deprecated custom_method debugfs interface that is
   problematic from the security standpoint (Rafael Wysocki).

 - Use %pe in a couple of places in the ACPI code for easier error
   decoding (Onkarnath).

* acpi-x86:
  ACPI: x86: Add DELL0501 handling to acpi_quirk_skip_serdev_enumeration()
  ACPI: x86: Move acpi_quirk_skip_serdev_enumeration() out of CONFIG_X86_ANDROID_TABLETS

* acpi-video:
  ACPI: video: Handle fetching EDID that is longer than 256 bytes

* acpi-apei:
  ACPI: APEI: Skip initialization of GHES_ASSIST structures for Machine Check Architecture
  ACPI: APEI: GHES: Convert to platform remove callback returning void

* acpi-misc:
  ACPI: pfr_update: Convert to platform remove callback returning void
  ACPI: pfr_telemetry: Convert to platform remove callback returning void
  ACPI: fan: Convert to platform remove callback returning void
  ACPI: GED: Convert to platform remove callback returning void
  ACPI: DPTF: Convert to platform remove callback returning void
  ACPI: AGDI: Convert to platform remove callback returning void
  ACPI: TAD: Convert to platform remove callback returning void
  ACPI: Drop the custom_method debugfs interface
  ACPI: use %pe for better readability of errors while printing
Loading
Loading
Loading
Loading
+0 −1
Original line number Diff line number Diff line
@@ -14,7 +14,6 @@ ACPI Support
   dsd/phy
   enumeration
   osi
   method-customizing
   method-tracing
   DSD-properties-rules
   debug
+0 −89
Original line number Diff line number Diff line
.. SPDX-License-Identifier: GPL-2.0

=======================================
Linux ACPI Custom Control Method How To
=======================================

:Author: Zhang Rui <rui.zhang@intel.com>


Linux supports customizing ACPI control methods at runtime.

Users can use this to:

1. override an existing method which may not work correctly,
   or just for debugging purposes.
2. insert a completely new method in order to create a missing
   method such as _OFF, _ON, _STA, _INI, etc.

For these cases, it is far simpler to dynamically install a single
control method rather than override the entire DSDT, because kernel
rebuild/reboot is not needed and test result can be got in minutes.

.. note::

  - Only ACPI METHOD can be overridden, any other object types like
    "Device", "OperationRegion", are not recognized. Methods
    declared inside scope operators are also not supported.

  - The same ACPI control method can be overridden for many times,
    and it's always the latest one that used by Linux/kernel.

  - To get the ACPI debug object output (Store (AAAA, Debug)),
    please run::

      echo 1 > /sys/module/acpi/parameters/aml_debug_output


1. override an existing method
==============================
a) get the ACPI table via ACPI sysfs I/F. e.g. to get the DSDT,
   just run "cat /sys/firmware/acpi/tables/DSDT > /tmp/dsdt.dat"
b) disassemble the table by running "iasl -d dsdt.dat".
c) rewrite the ASL code of the method and save it in a new file,
d) package the new file (psr.asl) to an ACPI table format.
   Here is an example of a customized \_SB._AC._PSR method::

      DefinitionBlock ("", "SSDT", 1, "", "", 0x20080715)
      {
         Method (\_SB_.AC._PSR, 0, NotSerialized)
         {
            Store ("In AC _PSR", Debug)
            Return (ACON)
         }
      }

   Note that the full pathname of the method in ACPI namespace
   should be used.
e) assemble the file to generate the AML code of the method.
   e.g. "iasl -vw 6084 psr.asl" (psr.aml is generated as a result)
   If parameter "-vw 6084" is not supported by your iASL compiler,
   please try a newer version.
f) mount debugfs by "mount -t debugfs none /sys/kernel/debug"
g) override the old method via the debugfs by running
   "cat /tmp/psr.aml > /sys/kernel/debug/acpi/custom_method"

2. insert a new method
======================
This is easier than overriding an existing method.
We just need to create the ASL code of the method we want to
insert and then follow the step c) ~ g) in section 1.

3. undo your changes
====================
The "undo" operation is not supported for a new inserted method
right now, i.e. we can not remove a method currently.
For an overridden method, in order to undo your changes, please
save a copy of the method original ASL code in step c) section 1,
and redo step c) ~ g) to override the method with the original one.


.. note:: We can use a kernel with multiple custom ACPI method running,
   But each individual write to debugfs can implement a SINGLE
   method override. i.e. if we want to insert/override multiple
   ACPI methods, we need to redo step c) ~ g) for multiple times.

.. note:: Be aware that root can mis-use this driver to modify arbitrary
   memory and gain additional rights, if root's privileges got
   restricted (for example if root is not allowed to load additional
   modules after boot).
+0 −14
Original line number Diff line number Diff line
@@ -449,20 +449,6 @@ config ACPI_HED
	  which is used to report some hardware errors notified via
	  SCI, mainly the corrected errors.

config ACPI_CUSTOM_METHOD
	tristate "Allow ACPI methods to be inserted/replaced at run time"
	depends on DEBUG_FS
	help
	  This debug facility allows ACPI AML methods to be inserted and/or
	  replaced without rebooting the system. For details refer to:
	  Documentation/firmware-guide/acpi/method-customizing.rst.

	  NOTE: This option is security sensitive, because it allows arbitrary
	  kernel memory to be written to by root (uid=0) users, allowing them
	  to bypass certain security measures (e.g. if root is not allowed to
	  load additional kernel modules after boot, this feature may be used
	  to override that restriction).

config ACPI_BGRT
	bool "Boottime Graphics Resource Table support"
	depends on EFI && (X86 || ARM64)
+0 −1
Original line number Diff line number Diff line
@@ -101,7 +101,6 @@ obj-$(CONFIG_ACPI_SBS) += sbshc.o
obj-$(CONFIG_ACPI_SBS)		+= sbs.o
obj-$(CONFIG_ACPI_HED)		+= hed.o
obj-$(CONFIG_ACPI_EC_DEBUGFS)	+= ec_sys.o
obj-$(CONFIG_ACPI_CUSTOM_METHOD)+= custom_method.o
obj-$(CONFIG_ACPI_BGRT)		+= bgrt.o
obj-$(CONFIG_ACPI_CPPC_LIB)	+= cppc_acpi.o
obj-$(CONFIG_ACPI_SPCR_TABLE)	+= spcr.o
+1 −1
Original line number Diff line number Diff line
@@ -161,7 +161,7 @@ static void cpufreq_add_device(const char *name)

	pdev = platform_device_register_simple(name, PLATFORM_DEVID_NONE, NULL, 0);
	if (IS_ERR(pdev))
		pr_info("%s device creation failed: %ld\n", name, PTR_ERR(pdev));
		pr_info("%s device creation failed: %pe\n", name, pdev);
}

#ifdef CONFIG_X86
Loading