Commit 81975080 authored by Frank Li's avatar Frank Li Committed by Shawn Guo
Browse files

arm64: dts: imx8-ss-dma: fix adc lpcg indices 



adc0_lpcg: clock-controller@5ac80000 {
	...						    Col1   Col2
	clocks = <&clk IMX_SC_R_ADC_0 IMX_SC_PM_CLK_PER>, // 0      0
		 <&dma_ipg_clk>;			  // 1      4
	clock-indices = <IMX_LPCG_CLK_0>, <IMX_LPCG_CLK_4>;
};

Col1: index, which existing dts try to get.
Col2: actual index in lpcg driver.

adc0: adc@5a880000 {
	clocks = <&adc0_lpcg 0>, <&adc0_lpcg 1>;
			     ^^              ^^
	clocks = <&adc0_lpcg IMX_LPCG_CLK_0>, <&adc0_lpcg IMX_LPCG_CLK_4>;

Arg0 is divided by 4 in lpcg driver. So adc get IMX_SC_PM_CLK_PER by
<&adc0_lpcg 0>, <&adc0_lpcg 1>. Although function can work, code logic is
wrong. Fix it by using correct indices.

Cc: stable@vger.kernel.org
Fixes: 1db044b2 ("arm64: dts: imx8dxl: add adc0 support")
Signed-off-by: default avatarFrank Li <Frank.Li@nxp.com>
Signed-off-by: default avatarShawn Guo <shawnguo@kernel.org>
parent 9055d87b

arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi

+4 −4
Original line number Diff line number Diff line
@@ -355,8 +355,8 @@ adc0: adc@5a880000 { 
		reg = <0x5a880000 0x10000>;

		interrupts = <GIC_SPI 240 IRQ_TYPE_LEVEL_HIGH>;

		interrupt-parent = <&gic>;

		clocks = <&adc0_lpcg 0>,

			 <&adc0_lpcg 1>;

		clocks = <&adc0_lpcg IMX_LPCG_CLK_0>,

			 <&adc0_lpcg IMX_LPCG_CLK_4>;

		clock-names = "per", "ipg";

		assigned-clocks = <&clk IMX_SC_R_ADC_0 IMX_SC_PM_CLK_PER>;

		assigned-clock-rates = <24000000>;
@@ -370,8 +370,8 @@ adc1: adc@5a890000 { 
		reg = <0x5a890000 0x10000>;

		interrupts = <GIC_SPI 241 IRQ_TYPE_LEVEL_HIGH>;

		interrupt-parent = <&gic>;

		clocks = <&adc1_lpcg 0>,

			 <&adc1_lpcg 1>;

		clocks = <&adc1_lpcg IMX_LPCG_CLK_0>,

			 <&adc1_lpcg IMX_LPCG_CLK_4>;

		clock-names = "per", "ipg";

		assigned-clocks = <&clk IMX_SC_R_ADC_1 IMX_SC_PM_CLK_PER>;

		assigned-clock-rates = <24000000>;