Commit 819bda58 authored by Bitterblue Smith's avatar Bitterblue Smith Committed by Kalle Valo
Browse files

wifi: rtlwifi: Ignore IEEE80211_CONF_CHANGE_RETRY_LIMITS 

Since commit 0a44dfc0 ("wifi: mac80211: simplify non-chanctx
drivers") ieee80211_hw_config() is no longer called with changed = ~0.
rtlwifi relied on ~0 in order to ignore the default retry limits of
4/7, preferring 48/48 in station mode and 7/7 in AP/IBSS.

RTL8192DU has a lot of packet loss with the default limits from
mac80211. Fix it by ignoring IEEE80211_CONF_CHANGE_RETRY_LIMITS
completely, because it's the simplest solution.

Link: https://lore.kernel.org/linux-wireless/cedd13d7691f4692b2a2fa5a24d44a22@realtek.com/


Cc: stable@vger.kernel.org # 6.9.x
Signed-off-by: default avatarBitterblue Smith <rtl8821cerfe2@gmail.com>
Acked-by: default avatarPing-Ke Shih <pkshih@realtek.com>
Signed-off-by: default avatarKalle Valo <kvalo@kernel.org>
Link: https://msgid.link/1fabb8e4-adf3-47ae-8462-8aea963bc2a5@gmail.com
parent 40cecaca

drivers/net/wireless/realtek/rtlwifi/core.c

+0 −15
Original line number Diff line number Diff line
@@ -633,21 +633,6 @@ static int rtl_op_config(struct ieee80211_hw *hw, u32 changed) 
		}

	}



	if (changed & IEEE80211_CONF_CHANGE_RETRY_LIMITS) {

		rtl_dbg(rtlpriv, COMP_MAC80211, DBG_LOUD,

			"IEEE80211_CONF_CHANGE_RETRY_LIMITS %x\n",

			hw->conf.long_frame_max_tx_count);

		/* brought up everything changes (changed == ~0) indicates first

		 * open, so use our default value instead of that of wiphy.

		 */

		if (changed != ~0) {

			mac->retry_long = hw->conf.long_frame_max_tx_count;

			mac->retry_short = hw->conf.long_frame_max_tx_count;

			rtlpriv->cfg->ops->set_hw_reg(hw, HW_VAR_RETRY_LIMIT,

				(u8 *)(&hw->conf.long_frame_max_tx_count));

		}

	}



	if (changed & IEEE80211_CONF_CHANGE_CHANNEL &&

	    !rtlpriv->proximity.proxim_on) {

		struct ieee80211_channel *channel = hw->conf.chandef.chan;