Commit 81a95c2b authored by Jeff Layton's avatar Jeff Layton Committed by Chuck Lever
Browse files

nfsd: remove unneeded EEXIST error check in nfsd_do_file_acquire 



Given that we do the search and insertion while holding the i_lock, I
don't think it's possible for us to get EEXIST here. Remove this case.

Fixes: c6593366 ("nfsd: don't kill nfsd_files because of lease break error")
Signed-off-by: default avatarJeff Layton <jlayton@kernel.org>
Tested-by: default avatarYouzhong Yang <youzhong@gmail.com>
Signed-off-by: default avatarChuck Lever <chuck.lever@oracle.com>
parent 8e6e2ffa

fs/nfsd/filecache.c

+0 −2
Original line number Diff line number Diff line
@@ -1037,8 +1037,6 @@ nfsd_file_do_acquire(struct svc_rqst *rqstp, struct svc_fh *fhp, 
	if (likely(ret == 0))

		goto open_file;



	if (ret == -EEXIST)

		goto retry;

	trace_nfsd_file_insert_err(rqstp, inode, may_flags, ret);

	status = nfserr_jukebox;

	goto construction_err;