Commit 81caa5d5 authored by Rafael J. Wysocki's avatar Rafael J. Wysocki
Browse files

thermal: imx: Drop critical trip check from imx_set_trip_temp() 



Because the IMX thermal driver does not flag its critical trip as
writable, imx_set_trip_temp() will never be invoked for it and so the
critical trip check can be dropped from there.

Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
Link: https://patch.msgid.link/2272035.iZASKD2KPV@rjwysocki.net
parent d1fbf18a

drivers/thermal/imx_thermal.c

+0 −9
Original line number Diff line number Diff line
@@ -335,21 +335,12 @@ static int imx_set_trip_temp(struct thermal_zone_device *tz, int trip_id, 
			     int temp)

{

	struct imx_thermal_data *data = thermal_zone_device_priv(tz);

	struct thermal_trip trip;

	int ret;



	ret = pm_runtime_resume_and_get(data->dev);

	if (ret < 0)

		return ret;



	ret = __thermal_zone_get_trip(tz, trip_id, &trip);

	if (ret)

		return ret;



	/* do not allow changing critical threshold */

	if (trip.type == THERMAL_TRIP_CRITICAL)

		return -EPERM;



	/* do not allow passive to be set higher than critical */

	if (temp < 0 || temp > trips[IMX_TRIP_CRITICAL].temperature)

		return -EINVAL;