Commit 81d96e8b authored by Yang Wang's avatar Yang Wang Committed by Alex Deucher
Browse files

drm/amdgpu: refine function signature of amdgpu_aca_get_error_data() 



refine function signature of amdgpu_aca_get_error_data();

Signed-off-by: default avatarYang Wang <kevinyang.wang@amd.com>
Reviewed-by: default avatarTao Zhou <tao.zhou1@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent 2dbe9c2b

drivers/gpu/drm/amd/amdgpu/amdgpu_aca.c

+3 −5
Original line number Diff line number Diff line
@@ -525,10 +525,9 @@ static bool aca_handle_is_valid(struct aca_handle *handle) 
}



int amdgpu_aca_get_error_data(struct amdgpu_device *adev, struct aca_handle *handle,

			      enum aca_error_type type, void *data, void *qctx)

			      enum aca_error_type type, struct ras_err_data *err_data,

			      struct ras_query_context *qctx)

{

	struct ras_err_data *err_data = (struct ras_err_data *)data;



	if (!handle || !err_data)

		return -EINVAL;
@@ -538,8 +537,7 @@ int amdgpu_aca_get_error_data(struct amdgpu_device *adev, struct aca_handle *han 
	if (!(BIT(type) & handle->mask))

		return  0;



	return __aca_get_error_data(adev, handle, type, err_data,

				    (struct ras_query_context *)qctx);

	return __aca_get_error_data(adev, handle, type, err_data, qctx);

}



static void aca_error_init(struct aca_error *aerr, enum aca_error_type type)

drivers/gpu/drm/amd/amdgpu/amdgpu_aca.h

+5 −1
Original line number Diff line number Diff line
@@ -26,6 +26,9 @@ 


#include <linux/list.h>



struct ras_err_data;

struct ras_query_context;



#define ACA_MAX_REGS_COUNT	(16)



#define ACA_REG_FIELD(x, h, l)			(((x) & GENMASK_ULL(h, l)) >> l)
@@ -198,7 +201,8 @@ int amdgpu_aca_add_handle(struct amdgpu_device *adev, struct aca_handle *handle, 
			  const char *name, const struct aca_info *aca_info, void *data);

void amdgpu_aca_remove_handle(struct aca_handle *handle);

int amdgpu_aca_get_error_data(struct amdgpu_device *adev, struct aca_handle *handle,

			      enum aca_error_type type, void *data, void *qctx);

			      enum aca_error_type type, struct ras_err_data *err_data,

			      struct ras_query_context *qctx);

int amdgpu_aca_smu_set_debug_mode(struct amdgpu_device *adev, bool en);

void amdgpu_aca_smu_debugfs_init(struct amdgpu_device *adev, struct dentry *root);

int aca_error_cache_log_bank_error(struct aca_handle *handle, struct aca_bank_info *info,