Commit 81f64165 authored by Baochen Qiang's avatar Baochen Qiang Committed by Jeff Johnson
Browse files

wifi: ath11k: adjust unlock sequence in ath11k_update_stats_event() 



Currently RCU lock and ar->data_lock are acquired in a sequence of

	rcu_read_lock()
	spin_lock_bh(&ar->data_lock)

but released in a sequence of

	rcu_read_unlock()
	spin_unlock_bh(&ar->data_lock)

Although there are no apparent issues with this, reorder them to
achieve symmetry.

Tested-on: WCN6855 hw2.0 PCI WLAN.HSP.1.1-03125-QCAHSPSWPL_V1_V2_SILICONZ_LITE-3.6510.37

Signed-off-by: default avatarBaochen Qiang <quic_bqiang@quicinc.com>
Acked-by: default avatarKalle Valo <kvalo@kernel.org>
Reviewed-by: default avatarVasanthakumar Thiagarajan <vasanthakumar.thiagarajan@oss.qualcomm.com>
Link: https://patch.msgid.link/20250220082448.31039-6-quic_bqiang@quicinc.com


Signed-off-by: default avatarJeff Johnson <jeff.johnson@oss.qualcomm.com>
parent 72610ed7

drivers/net/wireless/ath/ath11k/wmi.c

+1 −1
Original line number Diff line number Diff line
@@ -8238,8 +8238,8 @@ static void ath11k_update_stats_event(struct ath11k_base *ab, struct sk_buff *sk 


complete:

	complete(&ar->fw_stats_complete);

	rcu_read_unlock();

	spin_unlock_bh(&ar->data_lock);

	rcu_read_unlock();



	/* Since the stats's pdev, vdev and beacon list are spliced and reinitialised

	 * at this point, no need to free the individual list.