Commit 822e2bb0 authored by Marcos Paulo de Souza's avatar Marcos Paulo de Souza Committed by Petr Mladek
Browse files

drivers: serial: kgdboc: Drop checks for CON_ENABLED and CON_BOOT 



The original code tried to find a console that has CON_BOOT _or_
CON_ENABLED flag set. The flag CON_ENABLED is set to all registered
consoles, so in this case this check is always true, even for the
CON_BOOT consoles.

The initial intent of the kgdboc_earlycon_init was to get a console
early (CON_BOOT) or later on in the process (CON_ENABLED). The
code was using for_each_console macro, meaning that all console structs
were previously registered on the printk() machinery. At this point,
any console found on for_each_console is safe for kgdboc_earlycon_init
to use.

Dropping the check makes the code cleaner, and avoids further confusion
by future readers of the code.

Signed-off-by: default avatarMarcos Paulo de Souza <mpdesouza@suse.com>
Reviewed-by: default avatarPetr Mladek <pmladek@suse.com>
Link: https://patch.msgid.link/20251121-printk-cleanup-part2-v2-1-57b8b78647f4@suse.com


Signed-off-by: default avatarPetr Mladek <pmladek@suse.com>
parent 62627bf0

drivers/tty/serial/kgdboc.c

+0 −1
Original line number Diff line number Diff line
@@ -577,7 +577,6 @@ static int __init kgdboc_earlycon_init(char *opt) 
	console_list_lock();

	for_each_console(con) {

		if (con->write && con->read &&

		    (con->flags & (CON_BOOT | CON_ENABLED)) &&

		    (!opt || !opt[0] || strcmp(con->name, opt) == 0))

			break;

	}