Unverified Commit 82bb8db9 authored by Peter Ujfalusi's avatar Peter Ujfalusi Committed by Mark Brown
Browse files

ASoC: SOF: Intel: hda-pcm: Limit the maximum number of periods by MAX_BDL_ENTRIES 



The HDaudio specification Section 3.6.2 limits the number of BDL entries to 256.

Make sure we don't allow more periods than this normative value.

Signed-off-by: default avatarPeter Ujfalusi <peter.ujfalusi@linux.intel.com>
Signed-off-by: default avatarPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://patch.msgid.link/20240704090106.371497-1-pierre-louis.bossart@linux.intel.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 7441e7f3

sound/soc/sof/intel/hda-pcm.c

+6 −0
Original line number Diff line number Diff line
@@ -258,6 +258,12 @@ int hda_dsp_pcm_open(struct snd_sof_dev *sdev, 
	snd_pcm_hw_constraint_integer(substream->runtime,

				      SNDRV_PCM_HW_PARAM_PERIODS);



	/* Limit the maximum number of periods to not exceed the BDL entries count */

	if (runtime->hw.periods_max > HDA_DSP_MAX_BDL_ENTRIES)

		snd_pcm_hw_constraint_minmax(runtime, SNDRV_PCM_HW_PARAM_PERIODS,

					     runtime->hw.periods_min,

					     HDA_DSP_MAX_BDL_ENTRIES);



	/* Only S16 and S32 supported by HDA hardware when used without DSP */

	if (sdev->dspless_mode_selected)

		snd_pcm_hw_constraint_mask64(substream->runtime, SNDRV_PCM_HW_PARAM_FORMAT,