Commit 82bd83a0 authored by Dani Liberman's avatar Dani Liberman Committed by Lucas De Marchi
Browse files

drm/xe/irq: allocate all possible msix interrupts 



If platform supports MSIX, driver needs to allocate all possible
interrupts.

v2:
  - drop msix_cap and use the api return code instead.
  - fix commit message.

v3:
  - pass specific type in irq flags.

Cc: Ohad Sharabi <osharabi@habana.ai>
Cc: Lucas De Marchi <lucas.demarchi@intel.com>
Signed-off-by: default avatarDani Liberman <dliberman@habana.ai>
Reviewed-by: default avatarLucas De Marchi <lucas.demarchi@intel.com>
Signed-off-by: default avatarLucas De Marchi <lucas.demarchi@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240124075058.2302235-1-dliberman@habana.ai
parent eb538b55

drivers/gpu/drm/xe/xe_irq.c

+15 −2
Original line number Diff line number Diff line
@@ -683,8 +683,9 @@ static void irq_uninstall(struct drm_device *drm, void *arg) 
int xe_irq_install(struct xe_device *xe)

{

	struct pci_dev *pdev = to_pci_dev(xe->drm.dev);

	unsigned int irq_flags = PCI_IRQ_MSIX;

	irq_handler_t irq_handler;

	int err, irq;

	int err, irq, nvec;



	irq_handler = xe_irq_handler(xe);

	if (!irq_handler) {
@@ -694,7 +695,19 @@ int xe_irq_install(struct xe_device *xe) 


	xe_irq_reset(xe);



	err = pci_alloc_irq_vectors(pdev, 1, 1, PCI_IRQ_MSI | PCI_IRQ_MSIX);

	nvec = pci_msix_vec_count(pdev);

	if (nvec <= 0) {

		if (nvec == -EINVAL) {

			/* MSIX capability is not supported in the device, using MSI */

			irq_flags = PCI_IRQ_MSI;

			nvec = 1;

		} else {

			drm_err(&xe->drm, "MSIX: Failed getting count\n");

			return nvec;

		}

	}



	err = pci_alloc_irq_vectors(pdev, nvec, nvec, irq_flags);

	if (err < 0) {

		drm_err(&xe->drm, "MSI/MSIX: Failed to enable support %d\n", err);

		return err;