Commit 82d7e59e authored by Chen Ridong's avatar Chen Ridong Committed by Tejun Heo
Browse files

cgroup: switch to css_is_online() helper 



Use the new css_is_online() helper that has been introduced to check css
online state, instead of testing the CSS_ONLINE flag directly. This
improves readability and centralizes the state check logic.

No functional changes intended.

Signed-off-by: default avatarChen Ridong <chenridong@huawei.com>
Acked-by: default avatarShakeel Butt <shakeel.butt@linux.dev>
Reviewed-by: default avatarJan Kara <jack@suse.cz>
Signed-off-by: default avatarTejun Heo <tj@kernel.org>
parent 50133c09

fs/fs-writeback.c

+1 −1
Original line number Diff line number Diff line
@@ -981,7 +981,7 @@ void wbc_account_cgroup_owner(struct writeback_control *wbc, struct folio *folio 


	css = mem_cgroup_css_from_folio(folio);

	/* dead cgroups shouldn't contribute to inode ownership arbitration */

	if (!(css->flags & CSS_ONLINE))

	if (!css_is_online(css))

		return;



	id = css->id;

include/linux/memcontrol.h

+1 −1
Original line number Diff line number Diff line
@@ -893,7 +893,7 @@ static inline bool mem_cgroup_online(struct mem_cgroup *memcg) 
{

	if (mem_cgroup_disabled())

		return true;

	return !!(memcg->css.flags & CSS_ONLINE);

	return css_is_online(&memcg->css);

}



void mem_cgroup_update_lru_size(struct lruvec *lruvec, enum lru_list lru,

kernel/cgroup/cgroup.c

+2 −2
Original line number Diff line number Diff line
@@ -4948,7 +4948,7 @@ bool css_has_online_children(struct cgroup_subsys_state *css) 


	rcu_read_lock();

	css_for_each_child(child, css) {

		if (child->flags & CSS_ONLINE) {

		if (css_is_online(child)) {

			ret = true;

			break;

		}
@@ -5753,7 +5753,7 @@ static void offline_css(struct cgroup_subsys_state *css) 


	lockdep_assert_held(&cgroup_mutex);



	if (!(css->flags & CSS_ONLINE))

	if (!css_is_online(css))

		return;



	if (ss->css_offline)

mm/memcontrol.c

+1 −1
Original line number Diff line number Diff line
@@ -281,7 +281,7 @@ ino_t page_cgroup_ino(struct page *page) 
	/* page_folio() is racy here, but the entire function is racy anyway */

	memcg = folio_memcg_check(page_folio(page));



	while (memcg && !(memcg->css.flags & CSS_ONLINE))

	while (memcg && !css_is_online(&memcg->css))

		memcg = parent_mem_cgroup(memcg);

	if (memcg)

		ino = cgroup_ino(memcg->css.cgroup);

mm/page_owner.c

+1 −1
Original line number Diff line number Diff line
@@ -530,7 +530,7 @@ static inline int print_page_owner_memcg(char *kbuf, size_t count, int ret, 
	if (!memcg)

		goto out_unlock;



	online = (memcg->css.flags & CSS_ONLINE);

	online = css_is_online(&memcg->css);

	cgroup_name(memcg->css.cgroup, name, sizeof(name));

	ret += scnprintf(kbuf + ret, count - ret,

			"Charged %sto %smemcg %s\n",