Commit 82dadc8a authored by Caleb Sander Mateos's avatar Caleb Sander Mateos Committed by Jens Axboe
Browse files

io_uring/rsrc: take unsigned index in io_rsrc_node_lookup() 



io_rsrc_node_lookup() takes a signed int index as input and compares it
to an unsigned length. Since the signed int is implicitly cast to an
unsigned int for the comparison and the length is bounded by
IORING_MAX_FIXED_FILES/IORING_MAX_REG_BUFFERS, negative indices are
already rejected on architectures where int is at least 32 bits. Make
this a bit clearer and avoid compiler warnings for comparisons of
signed and unsigned values by taking an unsigned int index instead.

Signed-off-by: default avatarCaleb Sander Mateos <csander@purestorage.com>
Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 5247c034

io_uring/rsrc.h

+1 −1
Original line number Diff line number Diff line
@@ -90,7 +90,7 @@ bool io_check_coalesce_buffer(struct page **page_array, int nr_pages, 
			      struct io_imu_folio_data *data);



static inline struct io_rsrc_node *io_rsrc_node_lookup(struct io_rsrc_data *data,

						       int index)

						       unsigned int index)

{

	if (index < data->nr)

		return data->nodes[array_index_nospec(index, data->nr)];