Commit 82f36517 authored by Eric Dumazet's avatar Eric Dumazet Committed by Jakub Kicinski
Browse files

tcp: avoid dst->ops->check() call in tcp_v{4,6}_do_rcv() 



If incoming skb dst matches the socket cached one,
there is no need to call again dst->ops->check().

Network layer already validated the skb dst for us,
usually from tcp_v{4,6}_early_demux().

Signed-off-by: default avatarEric Dumazet <edumazet@google.com>
Reviewed-by: default avatarKuniyuki Iwashima <kuniyu@google.com>
Link: https://patch.msgid.link/20260306154322.1086539-1-edumazet@google.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 69274307

net/ipv4/tcp_ipv4.c

+1 −1
Original line number Diff line number Diff line
@@ -1855,7 +1855,7 @@ int tcp_v4_do_rcv(struct sock *sk, struct sk_buff *skb) 


		sock_rps_save_rxhash(sk, skb);

		sk_mark_napi_id(sk, skb);

		if (dst) {

		if (dst && unlikely(dst != skb_dst(skb))) {

			if (sk->sk_rx_dst_ifindex != skb->skb_iif ||

			    !INDIRECT_CALL_1(dst->ops->check, ipv4_dst_check,

					     dst, 0)) {

net/ipv6/tcp_ipv6.c

+1 −1
Original line number Diff line number Diff line
@@ -1596,7 +1596,7 @@ int tcp_v6_do_rcv(struct sock *sk, struct sk_buff *skb) 


		sock_rps_save_rxhash(sk, skb);

		sk_mark_napi_id(sk, skb);

		if (dst) {

		if (dst && unlikely(dst != skb_dst(skb))) {

			if (sk->sk_rx_dst_ifindex != skb->skb_iif ||

			    INDIRECT_CALL_1(dst->ops->check, ip6_dst_check,

					    dst, sk->sk_rx_dst_cookie) == NULL) {