Commit 8306ee08 authored by Heiner Kallweit's avatar Heiner Kallweit Committed by David S. Miller
Browse files

tg3: copy only needed fields from userspace-provided EEE data 



The current code overwrites fields in tp->eee with unchecked data from
edata, e.g. the bitmap with supported modes. ethtool properly returns
the received data from get_eee() call, but we have no guarantee that
other users of the ioctl set_eee() interface behave properly too.
Therefore copy only fields which are actually needed.

Signed-off-by: default avatarHeiner Kallweit <hkallweit1@gmail.com>
Reviewed-by: default avatarAndrew Lunn <andrew@lunn.ch>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent b0117d13

drivers/net/ethernet/broadcom/tg3.c

+3 −1
Original line number Diff line number Diff line
@@ -14200,7 +14200,9 @@ static int tg3_set_eee(struct net_device *dev, struct ethtool_keee *edata) 
		return -EINVAL;

	}



	tp->eee = *edata;

	tp->eee.eee_enabled = edata->eee_enabled;

	tp->eee.tx_lpi_enabled = edata->tx_lpi_enabled;

	tp->eee.tx_lpi_timer = edata->tx_lpi_timer;



	tp->phy_flags |= TG3_PHYFLG_USER_CONFIGURED;

	tg3_warn_mgmt_link_flap(tp);