Commit 8320b63e authored by Takashi Sakamoto's avatar Takashi Sakamoto
Browse files

firewire: core: add tracepoints events for flushing completions of isochronous context 

It is helpful to trace the flushing completions of isochronous context when
the core function is requested them by both in-kernel unit drivers and
userspace applications.

This commit adds some tracepoints events for the aim.

Link: https://lore.kernel.org/r/20240623220859.851685-6-o-takashi@sakamocchi.jp


Signed-off-by: default avatarTakashi Sakamoto <o-takashi@sakamocchi.jp>
parent c0b0ce6c

drivers/firewire/core-iso.c

+4 −0
Original line number Diff line number Diff line
@@ -207,6 +207,10 @@ EXPORT_SYMBOL(fw_iso_context_queue_flush); 


int fw_iso_context_flush_completions(struct fw_iso_context *ctx)

{

	trace_isoc_outbound_flush_completions(ctx);

	trace_isoc_inbound_single_flush_completions(ctx);

	trace_isoc_inbound_multiple_flush_completions(ctx);



	return ctx->card->driver->flush_iso_completions(ctx);

}

EXPORT_SYMBOL(fw_iso_context_flush_completions);

drivers/firewire/ohci.c

+2 −0
Original line number Diff line number Diff line
@@ -43,6 +43,8 @@ 
#include "packet-header-definitions.h"

#include "phy-packet-definitions.h"



#include <trace/events/firewire.h>



#define ohci_info(ohci, f, args...)	dev_info(ohci->card.device, f, ##args)

#define ohci_notice(ohci, f, args...)	dev_notice(ohci->card.device, f, ##args)

#define ohci_err(ohci, f, args...)	dev_err(ohci->card.device, f, ##args)

include/trace/events/firewire.h

+36 −0
Original line number Diff line number Diff line
@@ -706,6 +706,42 @@ DEFINE_EVENT_CONDITION(isoc_flush_template, isoc_inbound_multiple_flush, 
	TP_CONDITION(ctx->type == FW_ISO_CONTEXT_RECEIVE_MULTICHANNEL)

);



DECLARE_EVENT_CLASS(isoc_flush_completions_template,

	TP_PROTO(const struct fw_iso_context *ctx),

	TP_ARGS(ctx),

	TP_STRUCT__entry(

		__field(u64, context)

		__field(u8, card_index)

	),

	TP_fast_assign(

		__entry->context = (uintptr_t)ctx;

		__entry->card_index = ctx->card->index;

	),

	TP_printk(

		"context=0x%llx card_index=%u",

		__entry->context,

		__entry->card_index

	)

);



DEFINE_EVENT_CONDITION(isoc_flush_completions_template, isoc_outbound_flush_completions,

	TP_PROTO(const struct fw_iso_context *ctx),

	TP_ARGS(ctx),

	TP_CONDITION(ctx->type == FW_ISO_CONTEXT_TRANSMIT)

);



DEFINE_EVENT_CONDITION(isoc_flush_completions_template, isoc_inbound_single_flush_completions,

	TP_PROTO(const struct fw_iso_context *ctx),

	TP_ARGS(ctx),

	TP_CONDITION(ctx->type == FW_ISO_CONTEXT_RECEIVE)

);



DEFINE_EVENT_CONDITION(isoc_flush_completions_template, isoc_inbound_multiple_flush_completions,

	TP_PROTO(const struct fw_iso_context *ctx),

	TP_ARGS(ctx),

	TP_CONDITION(ctx->type == FW_ISO_CONTEXT_RECEIVE_MULTICHANNEL)

);



#undef QUADLET_SIZE



#endif // _FIREWIRE_TRACE_EVENT_H