Commit 832ecb01 authored by Mario Limonciello's avatar Mario Limonciello Committed by Jiri Kosina
Browse files

HID: amd_sfh: Default to HPD disabled 



Unless you know to look for it, HPD is a surprising behavior; particularly
because it can wake the system from suspend. It also has implications for
power consumption because sensors are left enabled.

After the sensors have been probed (and HPD is found present), explicitly
turn off HPD by default. Userspace can manually turn it on if desirable.

Cc: Pratap Nirujogi <pratap.nirujogi@amd.com>
Tested-by: default avatarAnson Tsao <anson.tsao@amd.com>
Signed-off-by: default avatarMario Limonciello <mario.limonciello@amd.com>
Signed-off-by: default avatarJiri Kosina <jkosina@suse.com>
parent e38764f6

drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_init.c

+1 −0
Original line number Diff line number Diff line
@@ -213,6 +213,7 @@ static int amd_sfh1_1_hid_client_init(struct amd_mp2_dev *privdata) 
			case HPD_IDX:

				privdata->dev_en.is_hpd_present = true;

				privdata->dev_en.is_hpd_enabled = true;

				amd_sfh_toggle_hpd(privdata, false);

				break;

			case ALS_IDX:

				privdata->dev_en.is_als_present = true;