Unverified Commit 8332e667 authored by Mingwei Zheng's avatar Mingwei Zheng Committed by Mark Brown
Browse files

spi: zynq-qspi: Add check for clk_enable() 



Add check for the return value of clk_enable() to catch the potential
error.

Fixes: c618a90d ("spi: zynq-qspi: Drop GPIO header")
Signed-off-by: default avatarMingwei Zheng <zmw12306@gmail.com>
Signed-off-by: default avatarJiasheng Jiang <jiashengjiangcool@gmail.com>
Link: https://patch.msgid.link/20241207015206.3689364-1-zmw12306@gmail.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent e5fca61f

drivers/spi/spi-zynq-qspi.c

+11 −2
Original line number Diff line number Diff line
@@ -379,12 +379,21 @@ static int zynq_qspi_setup_op(struct spi_device *spi) 
{

	struct spi_controller *ctlr = spi->controller;

	struct zynq_qspi *qspi = spi_controller_get_devdata(ctlr);

	int ret;



	if (ctlr->busy)

		return -EBUSY;



	clk_enable(qspi->refclk);

	clk_enable(qspi->pclk);

	ret = clk_enable(qspi->refclk);

	if (ret)

		return ret;



	ret = clk_enable(qspi->pclk);

	if (ret) {

		clk_disable(qspi->refclk);

		return ret;

	}



	zynq_qspi_write(qspi, ZYNQ_QSPI_ENABLE_OFFSET,

			ZYNQ_QSPI_ENABLE_ENABLE_MASK);