Unverified Commit 834e98ac authored by Pankaj Raghav's avatar Pankaj Raghav Committed by Christian Brauner
Browse files

fs: fix forced iversion increment on lazytime timestamp updates 

When updating timestamps with lazytime enabled, if only I_DIRTY_TIME is
set (pure lazytime update), inode_maybe_inc_iversion() should not be
forced to increment i_version. The force parameter should only be true
when actual data or metadata changes require an iversion bump.

The current code uses "!!dirty" which evaluates to true whenever dirty
has any bits set, including the I_DIRTY_TIME bit alone. This forces an
iversion increment on every lazytime timestamp update, which then sets
I_DIRTY_SYNC, triggering expensive log flushes on subsequent fdatasync
calls. Andres reported this issue when he noticed a perf regression[1].

Fix this by using "dirty != I_DIRTY_TIME" as the force parameter. This
passes false for pure lazytime updates (allowing the I_VERSION_QUERIED
optimization to work), while still forcing the increment when dirty
contains other flags indicating real changes that require iversion
updates.

[1] https://lore.kernel.org/linux-xfs/7ys6erh3nnyeerv2nybyfvp7dmaknuxrlxv74wx56ocdothkc6@ekfiadtkfn2r/



Fixes: 85c871a0 ("fs: add support for non-blocking timestamp updates")
Signed-off-by: default avatarPankaj Raghav <p.raghav@samsung.com>
Link: https://patch.msgid.link/20260511111918.1793689-1-p.raghav@samsung.com


Reviewed-by: default avatarJeff Layton <jlayton@kernel.org>
Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
Reviewed-by: default avatarCarlos Maiolino <cmaiolino@redhat.com>
Signed-off-by: default avatarChristian Brauner <brauner@kernel.org>
parent c3880a7b

fs/inode.c

+7 −1
Original line number Diff line number Diff line
@@ -2124,7 +2124,13 @@ static int inode_update_cmtime(struct inode *inode, unsigned int flags) 
			    inode_iversion_need_inc(inode))

				return -EAGAIN;

		} else {

			if (inode_maybe_inc_iversion(inode, !!dirty))

			/*

			 * Don't force iversion increment for pure lazytime

			 * updates (I_DIRTY_TIME only), let I_VERSION_QUERIED

			 * dictate whether the increment is needed.

			 */

			if (inode_maybe_inc_iversion(inode,

						     dirty != I_DIRTY_TIME))

				dirty |= I_DIRTY_SYNC;

		}

	}