Commit 8379ca68 authored by Uros Bizjak's avatar Uros Bizjak Committed by Ingo Molnar
Browse files

x86/asm/segment: Remove unnecessary "memory" clobber from savesegment() 



The savesegment() macro uses inline assembly to copy a segment register
into a general-purpose register:

  movl %seg, reg

This instruction does not access memory, yet the inline asm currently
declares a "memory" clobber, which unnecessarily acts as a compiler
barrier and may inhibit optimization.

Remove the "memory" clobber and mark the asm as `asm volatile` instead.
Segment register loads in the kernel are implemented using `asm volatile`,
so the compiler will not schedule segment register reads before those
loads. Using `asm volatile` preserves the intended ordering with other
segment register operations without imposing an unnecessary global memory
barrier.

No functional change intended.

Signed-off-by: default avatarUros Bizjak <ubizjak@gmail.com>
Signed-off-by: default avatarIngo Molnar <mingo@kernel.org>
Acked-by: default avatarPeter Zijlstra (Intel) <peterz@infradead.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: H. Peter Anvin <hpa@zytor.com>
Link: https://patch.msgid.link/20260330055823.5793-2-ubizjak@gmail.com
parent d9576c9c

arch/x86/include/asm/segment.h

+1 −1
Original line number Diff line number Diff line
@@ -348,7 +348,7 @@ static inline void __loadsegment_fs(unsigned short value) 
 * Save a segment register away:

 */

#define savesegment(seg, value)				\

	asm("movl %%" #seg ",%k0" : "=r" (value) : : "memory")

	asm volatile("movl %%" #seg ",%k0" : "=r" (value))



#endif /* !__ASSEMBLER__ */

#endif /* __KERNEL__ */