Commit 83da212b authored by Dan Carpenter's avatar Dan Carpenter Committed by Andrew Morton
Browse files

tools/testing: check correct variable in open_procmap() 

Check if "procmap_out->fd" is negative instead of "procmap_out" (which is
a pointer).

Link: https://lkml.kernel.org/r/aDbFuUTlJTBqziVd@stanley.mountain


Fixes: bd23f293 ("tools/testing: add PROCMAP_QUERY helper functions in mm self tests")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: default avatarLorenzo Stoakes <lorenzo.stoakes@oracle.com>
Cc: levi.yun <yeoreum.yun@arm.com>
Cc: Shuah Khan <shuah@kernel.org>
Cc: Wei Yang <richard.weiyang@gmail.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
parent 918850c1

tools/testing/selftests/mm/vm_util.c

+1 −1
Original line number Diff line number Diff line
@@ -439,7 +439,7 @@ int open_procmap(pid_t pid, struct procmap_fd *procmap_out) 
	sprintf(path, "/proc/%d/maps", pid);

	procmap_out->query.size = sizeof(procmap_out->query);

	procmap_out->fd = open(path, O_RDONLY);

	if (procmap_out < 0)

	if (procmap_out->fd < 0)

		ret = -errno;



	return ret;