Commit 83e3dc9a authored by Andrii Nakryiko's avatar Andrii Nakryiko Committed by Peter Zijlstra
Browse files

uprobes: simplify find_active_uprobe_rcu() VMA checks 



At the point where find_active_uprobe_rcu() is used we know that VMA in
question has triggered software breakpoint, so we don't need to validate
vma->vm_flags. Keep only vma->vm_file NULL check.

Suggested-by: default avatarOleg Nesterov <oleg@redhat.com>
Signed-off-by: default avatarAndrii Nakryiko <andrii@kernel.org>
Signed-off-by: default avatarPeter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: default avatarMasami Hiramatsu (Google) <mhiramat@kernel.org>
Acked-by: default avatarOleg Nesterov <oleg@redhat.com>
Link: https://lkml.kernel.org/r/20241122035922.3321100-2-andrii@kernel.org
parent 03a001b1

kernel/events/uprobes.c

+1 −1
Original line number Diff line number Diff line
@@ -2304,7 +2304,7 @@ static struct uprobe *find_active_uprobe_rcu(unsigned long bp_vaddr, int *is_swb 
	mmap_read_lock(mm);

	vma = vma_lookup(mm, bp_vaddr);

	if (vma) {

		if (valid_vma(vma, false)) {

		if (vma->vm_file) {

			struct inode *inode = file_inode(vma->vm_file);

			loff_t offset = vaddr_to_offset(vma, bp_vaddr);