Commit 83f3ac28 authored by Colin Ian King's avatar Colin Ian King Committed by Miri Korenblit
Browse files

wifi: iwlwifi: Fix incorrect logic on cmd_ver range checking 



The current cmd_ver range checking on cmd_ver < 1 && cmd_ver > 3 can
never be true because the logical operator && is being used, cmd_ver
can never be less than 1 and also greater than 3. Fix this by using
the logical || operator.

Fixes: df6146a0 ("wifi: iwlwifi: Add a new version for mac config command")

Signed-off-by: default avatarColin Ian King <colin.i.king@gmail.com>
Link: https://patch.msgid.link/20250522121703.2766764-1-colin.i.king@gmail.com


Signed-off-by: default avatarMiri Korenblit <miriam.rachel.korenblit@intel.com>
parent 432a4123

drivers/net/wireless/intel/iwlwifi/mvm/mld-mac.c

+1 −1
Original line number Diff line number Diff line
@@ -34,7 +34,7 @@ static void iwl_mvm_mld_mac_ctxt_cmd_common(struct iwl_mvm *mvm, 
					    WIDE_ID(MAC_CONF_GROUP,

						    MAC_CONFIG_CMD), 0);



	if (WARN_ON(cmd_ver < 1 && cmd_ver > 3))

	if (WARN_ON(cmd_ver < 1 || cmd_ver > 3))

		return;



	cmd->id_and_color = cpu_to_le32(mvmvif->id);