Commit 83f3cbcd authored by Naveen N Rao's avatar Naveen N Rao Committed by Sean Christopherson
Browse files

KVM: SVM: Replace hard-coded value 0x1FF with the corresponding macro 



The lower 9-bit field in EXITINFO2 represents an index into the AVIC
Physical/Logical APIC ID table for a AVIC_INCOMPLETE_IPI #VMEXIT. Since
the index into the Logical APIC ID table is just 8 bits, this field is
actually bound by the bit-width of the index into the AVIC Physical ID
table which is represented by AVIC_PHYSICAL_MAX_INDEX_MASK. So, use that
macro to mask EXITINFO2.Index instead of hard coding 0x1FF in
avic_incomplete_ipi_interception().

Co-developed-by: default avatarSuravee Suthikulpanit <suravee.suthikulpanit@amd.com>
Signed-off-by: default avatarSuravee Suthikulpanit <suravee.suthikulpanit@amd.com>
Signed-off-by: default avatarNaveen N Rao (AMD) <naveen@kernel.org>
Link: https://lore.kernel.org/r/95795f449c68bffcb3e1789ee2b0b7393711d37d.1757009416.git.naveen@kernel.org


Signed-off-by: default avatarSean Christopherson <seanjc@google.com>
parent f2f6e67a

arch/x86/kvm/svm/avic.c

+1 −1
Original line number Diff line number Diff line
@@ -579,7 +579,7 @@ int avic_incomplete_ipi_interception(struct kvm_vcpu *vcpu) 
	u32 icrh = svm->vmcb->control.exit_info_1 >> 32;

	u32 icrl = svm->vmcb->control.exit_info_1;

	u32 id = svm->vmcb->control.exit_info_2 >> 32;

	u32 index = svm->vmcb->control.exit_info_2 & 0x1FF;

	u32 index = svm->vmcb->control.exit_info_2 & AVIC_PHYSICAL_MAX_INDEX_MASK;

	struct kvm_lapic *apic = vcpu->arch.apic;



	trace_kvm_avic_incomplete_ipi(vcpu->vcpu_id, icrh, icrl, id, index);