Commit 84294c81 authored by Krzysztof Kozlowski's avatar Krzysztof Kozlowski Committed by Wolfram Sang
Browse files

i2c: simplify with scoped for each OF child loop 



Use scoped for_each_child_of_node_scoped() when iterating over device
nodes to make code a bit simpler.

Signed-off-by: default avatarKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: default avatarWolfram Sang <wsa+renesas@sang-engineering.com>
parent 6c909b6e

drivers/i2c/i2c-core-slave.c

+2 −5
Original line number Diff line number Diff line
@@ -109,16 +109,13 @@ EXPORT_SYMBOL_GPL(i2c_slave_event); 
bool i2c_detect_slave_mode(struct device *dev)

{

	if (IS_BUILTIN(CONFIG_OF) && dev->of_node) {

		struct device_node *child;

		u32 reg;



		for_each_child_of_node(dev->of_node, child) {

		for_each_child_of_node_scoped(dev->of_node, child) {

			of_property_read_u32(child, "reg", &reg);

			if (reg & I2C_OWN_SLAVE_ADDRESS) {

				of_node_put(child);

			if (reg & I2C_OWN_SLAVE_ADDRESS)

				return true;

		}

		}

	} else if (IS_BUILTIN(CONFIG_ACPI) && ACPI_HANDLE(dev)) {

		dev_dbg(dev, "ACPI slave is not supported yet\n");

	}