Commit 843750fb authored by Sakari Ailus's avatar Sakari Ailus Committed by Hans Verkuil
Browse files

media: tw9910: Don't set format in sub-device state 



For the purpose of setting old non-pad based sub-device try format as a
basis for VIDIOC_TRY_FMT implementation, there is no need to set the
format in the sub-device state. Drop the assignment to the state, which
would result in a NULL pointer dereference.

Fixes: fd17e3a9 ("media: i2c: Use accessors for pad config 'try_*' fields")
Signed-off-by: default avatarSakari Ailus <sakari.ailus@linux.intel.com>
Reviewed-by: default avatarLaurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
parent 09aee399

drivers/media/i2c/tw9910.c

+0 −2
Original line number Diff line number Diff line
@@ -829,8 +829,6 @@ static int tw9910_set_fmt(struct v4l2_subdev *sd, 
	if (format->which == V4L2_SUBDEV_FORMAT_ACTIVE)

		return tw9910_s_fmt(sd, mf);



	*v4l2_subdev_state_get_format(sd_state, 0) = *mf;



	return 0;

}