Commit 844436e0 authored by Dan Carpenter's avatar Dan Carpenter Committed by Steve French
Browse files

ksmbd: Unlock on in ksmbd_tcp_set_interfaces() 



Unlock before returning an error code if this allocation fails.

Fixes: 0626e664 ("cifsd: add server handler for central processing and tranport layers")
Cc: stable@vger.kernel.org # v5.15+
Signed-off-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Acked-by: default avatarNamjae Jeon <linkinjeon@kernel.org>
Signed-off-by: default avatarSteve French <stfrench@microsoft.com>
parent 78c5a6f1

fs/smb/server/transport_tcp.c

+3 −1
Original line number Diff line number Diff line
@@ -624,9 +624,11 @@ int ksmbd_tcp_set_interfaces(char *ifc_list, int ifc_list_sz) 
		for_each_netdev(&init_net, netdev) {

			if (netif_is_bridge_port(netdev))

				continue;

			if (!alloc_iface(kstrdup(netdev->name, GFP_KERNEL)))

			if (!alloc_iface(kstrdup(netdev->name, GFP_KERNEL))) {

				rtnl_unlock();

				return -ENOMEM;

			}

		}

		rtnl_unlock();

		bind_additional_ifaces = 1;

		return 0;