Commit 8445d9d3 authored by Jie Wang's avatar Jie Wang Committed by Paolo Abeni
Browse files

net: hns3: fix wrong use of semaphore up 



Currently, if hns3 PF or VF FLR reset failed after five times retry,
the reset done process will directly release the semaphore
which has already released in hclge_reset_prepare_general.
This will cause down operation fail.

So this patch fixes it by adding reset state judgement. The up operation is
only called after successful PF FLR reset.

Fixes: 8627bded ("net: hns3: refactor the precedure of PF FLR")
Fixes: f28368bb ("net: hns3: refactor the procedure of VF FLR")
Signed-off-by: default avatarJie Wang <wangjie125@huawei.com>
Signed-off-by: default avatarJijie Shao <shaojijie@huawei.com>
Signed-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
parent 7965a7f3

drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c

+2 −2
Original line number Diff line number Diff line
@@ -11516,7 +11516,7 @@ static void hclge_reset_done(struct hnae3_ae_dev *ae_dev) 
		dev_err(&hdev->pdev->dev, "fail to rebuild, ret=%d\n", ret);



	hdev->reset_type = HNAE3_NONE_RESET;

	clear_bit(HCLGE_STATE_RST_HANDLING, &hdev->state);

	if (test_and_clear_bit(HCLGE_STATE_RST_HANDLING, &hdev->state))

		up(&hdev->reset_sem);

}

drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c

+2 −2
Original line number Diff line number Diff line
@@ -1747,7 +1747,7 @@ static void hclgevf_reset_done(struct hnae3_ae_dev *ae_dev) 
			 ret);



	hdev->reset_type = HNAE3_NONE_RESET;

	clear_bit(HCLGEVF_STATE_RST_HANDLING, &hdev->state);

	if (test_and_clear_bit(HCLGEVF_STATE_RST_HANDLING, &hdev->state))

		up(&hdev->reset_sem);

}