Commit 8481d59b authored by Andrew Jeffery's avatar Andrew Jeffery
Browse files

soc: aspeed: lpc-snoop: Cleanup resources in stack-order 



Free the kfifo after unregistering the miscdev in
aspeed_lpc_disable_snoop() as the kfifo is initialised before the
miscdev in aspeed_lpc_enable_snoop().

Fixes: 3772e5da ("drivers/misc: Aspeed LPC snoop output using misc chardev")
Cc: stable@vger.kernel.org
Cc: Jean Delvare <jdelvare@suse.de>
Acked-by: default avatarJean Delvare <jdelvare@suse.de>
Link: https://patch.msgid.link/20250616-aspeed-lpc-snoop-fixes-v2-1-3cdd59c934d3@codeconstruct.com.au


Signed-off-by: default avatarAndrew Jeffery <andrew@codeconstruct.com.au>
parent 19272b37

drivers/soc/aspeed/aspeed-lpc-snoop.c

+1 −1
Original line number Diff line number Diff line
@@ -263,8 +263,8 @@ static void aspeed_lpc_disable_snoop(struct aspeed_lpc_snoop *lpc_snoop, 
		return;

	}



	kfifo_free(&lpc_snoop->chan[channel].fifo);

	misc_deregister(&lpc_snoop->chan[channel].miscdev);

	kfifo_free(&lpc_snoop->chan[channel].fifo);

}



static int aspeed_lpc_snoop_probe(struct platform_device *pdev)