Commit 84e95149 authored by Duoming Zhou's avatar Duoming Zhou Committed by Jakub Kicinski
Browse files

nfp: flower: handle acti_netdevs allocation failure 



The kmalloc_array() in nfp_fl_lag_do_work() will return null, if
the physical memory has run out. As a result, if we dereference
the acti_netdevs, the null pointer dereference bugs will happen.

This patch adds a check to judge whether allocation failure occurs.
If it happens, the delayed work will be rescheduled and try again.

Fixes: bb9a8d03 ("nfp: flower: monitor and offload LAG groups")
Signed-off-by: default avatarDuoming Zhou <duoming@zju.edu.cn>
Reviewed-by: default avatarLouis Peens <louis.peens@corigine.com>
Link: https://lore.kernel.org/r/20240308142540.9674-1-duoming@zju.edu.cn


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 46590b54

drivers/net/ethernet/netronome/nfp/flower/lag_conf.c

+5 −0
Original line number Diff line number Diff line
@@ -337,6 +337,11 @@ static void nfp_fl_lag_do_work(struct work_struct *work) 


		acti_netdevs = kmalloc_array(entry->slave_cnt,

					     sizeof(*acti_netdevs), GFP_KERNEL);

		if (!acti_netdevs) {

			schedule_delayed_work(&lag->work,

					      NFP_FL_LAG_DELAY);

			continue;

		}



		/* Include sanity check in the loop. It may be that a bond has

		 * changed between processing the last notification and the