Commit 84ed4545 authored by Marc Zyngier's avatar Marc Zyngier
Browse files

KVM: arm64: Simplify visibility handling of AArch32 SPSR_* 



Since SPSR_* are not associated with any register in the sysreg array,
nor do they have .get_user()/.set_user() helpers, they are invisible to
userspace with that encoding.

Therefore hidden_user_visibility() serves no purpose here, and can be
safely removed.

Reviewed-by: default avatarOliver Upton <oliver.upton@linux.dev>
Link: https://lore.kernel.org/r/20240904082419.1982402-3-maz@kernel.org


Signed-off-by: default avatarMarc Zyngier <maz@kernel.org>
parent 989fce63

arch/arm64/kvm/sys_regs.c

+4 −8
Original line number Diff line number Diff line
@@ -2770,14 +2770,10 @@ static const struct sys_reg_desc sys_reg_descs[] = { 
	{ SYS_DESC(SYS_SP_EL1), access_sp_el1},



	/* AArch32 SPSR_* are RES0 if trapped from a NV guest */

	{ SYS_DESC(SYS_SPSR_irq), .access = trap_raz_wi,

	  .visibility = hidden_user_visibility },

	{ SYS_DESC(SYS_SPSR_abt), .access = trap_raz_wi,

	  .visibility = hidden_user_visibility },

	{ SYS_DESC(SYS_SPSR_und), .access = trap_raz_wi,

	  .visibility = hidden_user_visibility },

	{ SYS_DESC(SYS_SPSR_fiq), .access = trap_raz_wi,

	  .visibility = hidden_user_visibility },

	{ SYS_DESC(SYS_SPSR_irq), .access = trap_raz_wi },

	{ SYS_DESC(SYS_SPSR_abt), .access = trap_raz_wi },

	{ SYS_DESC(SYS_SPSR_und), .access = trap_raz_wi },

	{ SYS_DESC(SYS_SPSR_fiq), .access = trap_raz_wi },



	{ SYS_DESC(SYS_IFSR32_EL2), trap_undef, reset_unknown, IFSR32_EL2 },

	EL2_REG(AFSR0_EL2, access_rw, reset_val, 0),