Commit 84f2902b authored by Harold Sun's avatar Harold Sun Committed by Alex Deucher
Browse files

drm/amd/display: Added case for when RR equals panel's max RR using freesync 



[WHY]
Rounding error sometimes occurs when the refresh rate is equal to a panel's
max refresh rate, causing HDMI compliance failures.

[HOW]
Added a case so that we round up to avoid v_total_min to be below a panel's
minimum bound.

Reviewed-by: default avatarJun Lei <jun.lei@amd.com>
Signed-off-by: default avatarHarold Sun <Harold.Sun@amd.com>
Signed-off-by: default avatarRay Wu <ray.wu@amd.com>
Tested-by: default avatarDaniel Wheeler <daniel.wheeler@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
(cherry picked from commit fe7645d2)
parent 34659c1a

drivers/gpu/drm/amd/display/dc/dc_hw_types.h

+1 −0
Original line number Diff line number Diff line
@@ -974,6 +974,7 @@ struct dc_crtc_timing { 
	uint32_t pix_clk_100hz;



	uint32_t min_refresh_in_uhz;

	uint32_t max_refresh_in_uhz;



	uint32_t vic;

	uint32_t hdmi_vic;

drivers/gpu/drm/amd/display/modules/freesync/freesync.c

+8 −0
Original line number Diff line number Diff line
@@ -155,6 +155,14 @@ unsigned int mod_freesync_calc_v_total_from_refresh( 
		v_total = div64_u64(div64_u64(((unsigned long long)(

				frame_duration_in_ns) * (stream->timing.pix_clk_100hz / 10)),

				stream->timing.h_total), 1000000);

	} else if (refresh_in_uhz >= stream->timing.max_refresh_in_uhz) {

		/* When the target refresh rate is the maximum panel refresh rate

		 * round up the vtotal value to prevent off-by-one error causing

		 * v_total_min to be below the panel's lower bound

		 */

		v_total = div64_u64(div64_u64(((unsigned long long)(

				frame_duration_in_ns) * (stream->timing.pix_clk_100hz / 10)),

				stream->timing.h_total) + (1000000 - 1), 1000000);

	} else {

		v_total = div64_u64(div64_u64(((unsigned long long)(

				frame_duration_in_ns) * (stream->timing.pix_clk_100hz / 10)),