Commit 8527bbb3 authored by Denis Arefev's avatar Denis Arefev Committed by Takashi Iwai
Browse files

ALSA: hda: cs35l41: Fix NULL pointer dereference in cs35l41_get_acpi_mute_state() 



Return value of a function acpi_evaluate_dsm() is dereferenced  without
checking for NULL, but it is usually checked for this function.

acpi_evaluate_dsm() may return NULL, when acpi_evaluate_object() returns
acpi_status other than ACPI_SUCCESS, so add a check to prevent the crach.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Fixes: 447106e9 ("ALSA: hda: cs35l41: Support mute notifications for CS35L41 HDA")
Cc: stable@vger.kernel.org
Signed-off-by: default avatarDenis Arefev <arefev@swemel.ru>
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent ca7a2317

sound/hda/codecs/side-codecs/cs35l41_hda.c

+2 −0
Original line number Diff line number Diff line
@@ -1410,6 +1410,8 @@ static int cs35l41_get_acpi_mute_state(struct cs35l41_hda *cs35l41, acpi_handle 


	if (cs35l41_dsm_supported(handle, CS35L41_DSM_GET_MUTE)) {

		ret = acpi_evaluate_dsm(handle, &guid, 0, CS35L41_DSM_GET_MUTE, NULL);

		if (!ret)

			return -EINVAL;

		mute = *ret->buffer.pointer;

		dev_dbg(cs35l41->dev, "CS35L41_DSM_GET_MUTE: %d\n", mute);

	}