Commit 85463eb6 authored by Michael Margolin's avatar Michael Margolin Committed by Jason Gunthorpe
Browse files

RDMA/efa: Remove possible negative shift 

The page size used for device might in some cases be smaller than
PAGE_SIZE what results in a negative shift when calculating the number of
host pages in PAGE_SIZE for a debug log. Remove the debug line together
with the calculation.

Fixes: 40909f66 ("RDMA/efa: Add EFA verbs implementation")
Link: https://patch.msgid.link/r/20251210173656.8180-1-mrgolin@amazon.com


Reviewed-by: default avatarTom Sela <tomsela@amazon.com>
Reviewed-by: default avatarYonatan Nachum <ynachum@amazon.com>
Signed-off-by: default avatarMichael Margolin <mrgolin@amazon.com>
Reviewed-by: default avatarGal Pressman <gal.pressman@linux.dev>
Signed-off-by: default avatarJason Gunthorpe <jgg@nvidia.com>
parent c1776ccb

drivers/infiniband/hw/efa/efa_verbs.c

+0 −4
Original line number Diff line number Diff line
@@ -1320,13 +1320,9 @@ static int umem_to_page_list(struct efa_dev *dev, 
			     u32 hp_cnt,

			     u8 hp_shift)

{

	u32 pages_in_hp = BIT(hp_shift - PAGE_SHIFT);

	struct ib_block_iter biter;

	unsigned int hp_idx = 0;



	ibdev_dbg(&dev->ibdev, "hp_cnt[%u], pages_in_hp[%u]\n",

		  hp_cnt, pages_in_hp);



	rdma_umem_for_each_dma_block(umem, &biter, BIT(hp_shift))

		page_list[hp_idx++] = rdma_block_iter_dma_address(&biter);